Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TeacherDataService): Clean up pause period code #1460

Merged
merged 1 commit into from
Oct 11, 2023
Merged

refactor(TeacherDataService): Clean up pause period code #1460

merged 1 commit into from
Oct 11, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 10, 2023 •
edited
Loading

Changes

  • Remove unused functions
    • isPeriodPaused()
    • isAllPeriodsPaused()
  • Move isAnyPeriodPaused() to TopBarComponent (only place it's used)
  • Rename sendRunStatus -> saveRunStatus
  • Add private modifiers, variable types and return values

Test

  • Pause/Unpause screen works as before for teacher and student
  • Red dot indicator appears over pause icon in CM when any period is paused

@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 10, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 10, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 10, 2023 16:44
geoffreykwan
geoffreykwan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 896f62b into develop Oct 11, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the refactor-teacherDataService-remove-unused-functions-pause-period branch October 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development
Status: Done
Milestone
Tech Debt 19 -> 18
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan