Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NodeService): Remove scrollToComponentAndHighlight() #1459

Merged
merged 1 commit into from
Oct 10, 2023
Merged

refactor(NodeService): Remove scrollToComponentAndHighlight() #1459

merged 1 commit into from
Oct 10, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 9, 2023 •
edited
Loading

Changes

  • Use existing functions in dom.ts instead of NodeService.scrollToComponentAndHighlight(). This only affects the WISE link feature when we need to scroll and highlight a specific component in the same step or in a different step.

Test

  • WISE links work as before, when link is
    • in the same step
    • in a different step -> should go to new step
    • (regardless of same/different step): to a specific component -> should scroll to component and highlight it

@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 9, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 9, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 9, 2023 20:50
geoffreykwan
geoffreykwan approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit ce5bda2 into develop Oct 10, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the refactor-node-service-remove-scrollToComponentAndHighlight branch October 10, 2023 15:52
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.115.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 19 -> 18
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan