Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Manage Students): Sometimes does not load any workgroups #1452

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(Manage Students): Sometimes does not load any workgroups #1452

merged 1 commit into from
Oct 6, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

Clear current period when leaving Classroom Monitor.

Test

  1. Sign in as a teacher that has at least two runs that have workgroups
  2. Load the Manage Students view for the first run by clicking on the "X students" link. You should see workgroups.
  3. Click the back button on your browser
  4. Load the Manage Students view for the second run by clicking on the "X students" link. The Manage Students view loads and should show the workgroups. It used to not show any workgroups.

Closes #1451

@geoffreykwan geoffreykwan self-assigned this Oct 4, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 4, 2023 22:09
hirokiterashima
hirokiterashima approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 44a0995 into develop Oct 6, 2023
@geoffreykwan geoffreykwan deleted the issue-1451-manage-students-sometimes-does-not-load-workgroups branch October 6, 2023 14:40
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.115.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
released
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Manage Students): Sometimes does not load any workgroups
2 participants
@geoffreykwan @hirokiterashima