Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NotificationService): getNewNotifications() #1439

Merged
merged 1 commit into from
Oct 3, 2023
Merged

refactor(NotificationService): getNewNotifications() #1439

merged 1 commit into from
Oct 3, 2023

Conversation

hirokiterashima
Copy link
Member

Changes

  • Use HOF's to reduce nesting
  • Reduce return statements and unnecessary variable declaration
  • Change let to const where appropriate
  • Remove unnecessary comment

Test

  • New notifications are displayed in latest (top) -> oldest (bottom) order as before

@hirokiterashima
refactor(NotificationService): getNewNotifications()
04850c8 
Reduce complexity with HOF's and reducing return statements
Change lets to consts where appropriate
@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone Oct 1, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 1, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 1, 2023 23:15
geoffreykwan
geoffreykwan approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 9435534 into develop Oct 3, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the refactor-notification-service-get-new-notifications branch October 3, 2023 22:58
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.115.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan