test(Multiple Choice): Add tests to Multiple Choice authoring #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breity
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Test are working. 👍
A couple thoughts:
- Could maybe reorganize to better follow the Arrange-Act-Assert pattern by moving the actions out of the
itblocks and into thebeforeEachblocks, leaving only assertions in theitblocks. - Wondering if we need all the click action function wrappers that are only used once. Could you call the click actions directly?
These are probably issues we should discuss, agree on conventions for test structures. So maybe okay to move forward here either way.
breity
approved these changes
Oct 11, 2023
geoffreykwan
force-pushed
the
add-multiple-choice-authoring-tests
branch
from
ae98068 to
88de34e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added tests to Multiple Choice authoring.
Test
Only test files were changed/added so functionality should not have changed.