Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Peer Group): Non admins can not create new peer groupings #1434

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Sep 26, 2023

Changes

Show the appropriate error message when an error is returned from the server.

Test

Closes #1433

Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I updated messages.xlf with the error message string changes.

@geoffreykwan geoffreykwan merged commit cba91ca into develop Sep 28, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1433-can-not-create-peer-grouping branch September 28, 2023 17:00
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.114.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(Peer Group): Can not create new peer grouping
3 participants