Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ProjectAuthoringComponent): Extract ProjectAuthoringParentComponent #1427

Merged
merged 1 commit into from
Sep 21, 2023
Merged

refactor(ProjectAuthoringComponent): Extract ProjectAuthoringParentComponent #1427

merged 1 commit into from
Sep 21, 2023

Conversation

hirokiterashima
Copy link
Member

Changes

  • Create new ProjectAuthoringParentComponent, which maps to 'edit/unit/${unitId}' route (see authoring-routing.module.ts)
    • ProjectAuthoringComponent now maps to '' route within the 'edit/unit/${unitId}' route
  • Move the router-outlet and concurrent-authors-messages blocks from project-authoring.component.html to project-authoring-parent.component.html
  • Clean up code

Test

  • Project authoring works as before, especially:
    • concurrent authors message
    • moving/copying nodes highlight and scroll to new node positions
    • styling of project-level pages (info, notebook, etc) look ok
    • node authoring works as before

@hirokiterashima
refactor(ProjectAuthoringCompoonent): Extract
c771391 
ProjectAuthoringParentComponent
@hirokiterashima hirokiterashima added this to the Tech Debt 20 -> 19 milestone Sep 20, 2023
@hirokiterashima hirokiterashima self-assigned this Sep 20, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review September 20, 2023 23:03
@hirokiterashima hirokiterashima changed the title refactor(ProjectAuthoringCompoonent): Extract ProjectAuthoringParentComponent refactor(ProjectAuthoringComponent): Extract ProjectAuthoringParentComponent Sep 20, 2023
geoffreykwan
geoffreykwan approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 4f607ea into develop Sep 21, 2023
@hirokiterashima hirokiterashima deleted the extract-project-authoring-parent-component branch September 21, 2023 16:54
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.114.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development
Status: Done
Milestone
Tech Debt 20 -> 19
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan