Skip to content

Commit

Permalink
Fix progress bar, VLE annotations, additional styles
Browse files Browse the repository at this point in the history
  • Loading branch information
breity committed Oct 23, 2023
1 parent 1ba5b9a commit e00dd16
Show file tree
Hide file tree
Showing 35 changed files with 228 additions and 158 deletions.
22 changes: 14 additions & 8 deletions src/app/classroom-monitor/milestones/milestones.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,28 @@
<mat-card
appearance="outlined"
*ngFor="let milestone of milestones"
class="milestone md-button"
md-ink-ripple
class="milestone"
role="button"
tabindex="0"
aria-label="Show milestone details"
i18-aria-label
(click)="showMilestoneDetails(milestone, $event)"
(keyup.enter)="showMilestoneDetails(milestone, $event)"
>
<mat-card-content fxLayout="column" fxLayoutAlign="center center">
<div class="milestone__title" md-truncate>{{ milestone.name }}</div>
<div class="milestone__progress">
<div class="milestone__progress mat-app-background">
<mat-progress-spinner
diameter="96"
mode="determinate"
[value]="milestone.percentageCompleted"
[ngClass]="{ success: milestone.percentageCompleted === 100 }"
></mat-progress-spinner>
<div class="milestone__progress__percent" fxLayout="row" fxLayoutAlign="center center">
<div
class="milestone__progress__percent mat-subtitle-2"
fxLayout="row"
fxLayoutAlign="center center"
>
<span *ngIf="milestone.percentageCompleted < 100"
>{{ milestone.percentageCompleted }}%</span
>
Expand All @@ -26,13 +34,11 @@
</mat-icon>
</div>
</div>
<p class="md-body-1 text-secondary">
<p class="text-secondary" i18n>
{{ milestone.numberOfStudentsCompleted }}/{{ milestone.numberOfStudentsInRun }} teams
completed
</p>
<p *ngIf="milestone.isReportAvailable" class="md-body-2 info" i18n>
~ Report Available ~
</p>
<p *ngIf="milestone.isReportAvailable" class="info" i18n>~ Report Available ~</p>
</mat-card-content>
</mat-card>
</div>
Expand Down
45 changes: 45 additions & 0 deletions src/app/classroom-monitor/milestones/milestones.component.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,48 @@
:host ::ng-deep .success circle {
stroke: #00C853;
}

.milestone {
min-width: 196px;
width: 196px;
min-height: 242px;
background-color: #ffffff;
padding: 0;
margin: 4px;
cursor: pointer;
}

.milestone__progress {
border-radius: 50%;
position: relative;
margin-bottom: 12px;
}

.milestone__progress__percent {
position: absolute;
top: 8px;
bottom: 8px;
left: 8px;
right: 8px;
border-radius: 50%;
background-color: #ffffff;
font-weight: 500;
}

.milestone__title {
font-weight: 700;
margin-bottom: 12px;
}

.milestone--add {
&.md-button {
text-transform: uppercase;
}
}

.milestone--add__icon {
height: 96px;
width: 96px;
background-color: color('gray-lighter');
border-radius: 50%;
}
Original file line number Diff line number Diff line change
@@ -1,10 +0,0 @@

.progress-wrapper {
.mat-mdc-progress-bar, .mdc-linear-progress__bar-inner {
height: 14px;
}

.mdc-linear-progress__bar-inner {
border-top-width: 14px;
}
}
2 changes: 1 addition & 1 deletion src/app/student/account/edit/edit.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</header>

<section>
<mat-tab-group>
<mat-tab-group mat-stretch-tabs="false">
<mat-tab i18n-label label="Account Info">
<div class="section__tab">
<student-edit-profile></student-edit-profile>
Expand Down
2 changes: 1 addition & 1 deletion src/app/teacher/account/edit/edit.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</header>

<section>
<mat-tab-group>
<mat-tab-group mat-stretch-tabs="false">
<mat-tab i18n-label label="Account Info">
<div class="section__tab">
<teacher-edit-profile></teacher-edit-profile>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
[diameter]="24"
>
</mat-spinner>
<span *ngIf="globalMessage.text" class="component__actions__info md-caption global-message">
<span *ngIf="globalMessage.text" class="component__actions__info mat-small global-message">
{{ globalMessage.text }} {{ globalMessage.time | date: 'medium' }}
</span>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
mat-form-field {
width: 100%;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
mat-form-field {
width: 64px;
}

input {
text-align: center;
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
<div fxLayout="row" fxLayoutAlign="start center">
<nav-item-progress
[period]="currentPeriod"
[nodeCompletion]="milestone.percentageCompleted"></nav-item-progress>
[nodeCompletion]="milestone.percentageCompleted"
></nav-item-progress>
</div>
</div>
<p *ngIf="milestone.description">
Expand Down Expand Up @@ -49,7 +50,11 @@
</section>
<section class="mat-elevation-z1 app-bg-bg">
<div *ngIf="milestone.generatedRecommendations && milestone.isReportAvailable">
<mat-tab-group (selectedTabChange)="saveTabSelectedEvent($event)" class="notice-bg-bg">
<mat-tab-group
(selectedTabChange)="saveTabSelectedEvent($event)"
mat-stretch-tabs="false"
class="notice-bg-bg"
>
<mat-tab label="Recommendation" i18n-label>
<div class="milestone-details__section" [innerHTML]="recommendations"></div>
</mat-tab>
Expand Down Expand Up @@ -92,7 +97,9 @@
account_circle
</mat-icon>
</span>
<span class="mat-subtitle-2">{{ getDisplayNamesByWorkgroupId(workgroup.workgroupId) }}</span>
<span class="mat-subtitle-2">{{
getDisplayNamesByWorkgroupId(workgroup.workgroupId)
}}</span>
</span>
<span fxFlex></span>
<span class="mat-subtitle-2">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
fxLayoutAlign="center center"
>
<span
class="md-display-1"
class="mat-headline-5"
[ngClass]="{ success: changeInScore > 0, warn: changeInScore < 0 }"
>
<span *ngIf="changeInScore > 0">+</span>{{ changeInScore }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@
.mdc-list-item.mdc-list-item--with-one-line {
height: auto;
}

.mat-headline-5 {
margin: 0;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}

.mat-mdc-card-actions {
padding: 8px 16px;
padding: 0 16px;
border-top: 1px solid #dddddd;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<mat-toolbar class="mat-elevation-z1 toolbar">
<div class="md-toolbar-tools toolbar__tools">
<div class="toolbar__tools" fxLayout="row" fxLayoutAlign="start center">
<button
mat-icon-button
aria-label="Main Menu"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@

.toolbar__tools {
padding: 0 4px;
width: 100%;
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div layout="row" layout-align="center center" class="layout-align-center-center layout-row">
<span class="md-display-1">{{ score }}</span
>&nbsp;<span class="md-title text-secondary normal">/{{ maxScore }}</span>
<div fxLayout="row" fxLayoutAlign="center center">
<span class="mat-headline-5">{{ score }}</span
>&nbsp;<span class="text-secondary mat-body-2">/{{ maxScore }}</span>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.mat-headline-5 {
margin: 0;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { Input, Component } from '@angular/core';

@Component({
selector: 'workgroup-node-score',
templateUrl: 'workgroup-node-score.component.html'
templateUrl: 'workgroup-node-score.component.html',
styleUrls: ['workgroup-node-score.component.scss']
})
export class WorkgroupNodeScoreComponent {
@Input()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +0,0 @@
.project-progress {
.nav-item__progress {
height: 14px;

.mdc-linear-progress__bar-inner {
border-top-width: 14px;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@
fxLayoutAlign="center center"
class="layout-align-center-center layout-row"
>
<span class="md-display-1">{{ team.score }}</span
<span class="mat-headline-5">{{ team.score }}</span
>&nbsp;
<span class="md-title text-secondary normal">/{{ team.maxScore }}</span>
<span class="text-secondary mat-body-2">/{{ team.maxScore }}</span>
</div>
</td>
</tr>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,8 @@
background-color: #f5f5f5;
}
}

.mat-headline-5 {
margin: 0;
}
}
1 change: 1 addition & 0 deletions src/assets/wise5/components/draw/drawing-tool.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ sans-serif;
.dt-container {
white-space: nowrap;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
overflow: auto;

.dt-canvas-container {
vertical-align: top; // not needed but why not
Expand Down
2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/author.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/author.css.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ h3.component__header {
.component__actions__info {
font-style: italic;
margin-left: 8px;
//color: color('accent-1');
color: color('text-secondary');
font-weight: 400;
}

.component__actions__more {
Expand Down
88 changes: 44 additions & 44 deletions src/assets/wise5/themes/default/style/modules/_milestones.scss
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
.milestone {
min-width: 196px;
width: 196px;
height: 242px;
background-color: #ffffff;
padding: 0;
// .milestone {
// min-width: 196px;
// width: 196px;
// height: 242px;
// background-color: #ffffff;
// padding: 0;

&.md-button {
text-transform: none;
}
}
// &.md-button {
// text-transform: none;
// }
// }

.milestone__progress {
background-color: color('gray-lighter');
border-radius: 50%;
position: relative;
margin-bottom: 12px;
}
// .milestone__progress {
// background-color: color('gray-lighter');
// border-radius: 50%;
// position: relative;
// margin-bottom: 12px;
// }

.milestone__progress__percent {
position: absolute;
top: 8px;
bottom: 8px;
left: 8px;
right: 8px;
border-radius: 50%;
background-color: #ffffff;
color: color('primary');
font-size: rem(2.8);
font-weight: 500;
}
// .milestone__progress__percent {
// position: absolute;
// top: 8px;
// bottom: 8px;
// left: 8px;
// right: 8px;
// border-radius: 50%;
// background-color: #ffffff;
// color: color('primary');
// font-size: rem(2.8);
// font-weight: 500;
// }

.milestone__title {
font-weight: 700;
font-size: $body-font-size-base;
margin-bottom: 12px;
}
// .milestone__title {
// font-weight: 700;
// font-size: $body-font-size-base;
// margin-bottom: 12px;
// }

.milestone--add {
&.md-button {
text-transform: uppercase;
}
}
// .milestone--add {
// &.md-button {
// text-transform: uppercase;
// }
// }

.milestone--add__icon {
height: 96px;
width: 96px;
background-color: color('gray-lighter');
border-radius: 50%;
}
// .milestone--add__icon {
// height: 96px;
// width: 96px;
// background-color: color('gray-lighter');
// border-radius: 50%;
// }
2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/monitor.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/monitor.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/vle.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/wise5/themes/default/style/vle.css.map

Large diffs are not rendered by default.

Loading

0 comments on commit e00dd16

Please sign in to comment.