getLatestAnnotations() return null instead of undefined

Refactor matchesScoreType()
WISE-Community · Oct 16, 2023 · 63332bd · 63332bd
1 parent 5191b41
commit 63332bd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/app/services/annotationService.spec.ts b/src/app/services/annotationService.spec.ts
@@ -66,7 +66,7 @@ function getLatestScoreAnnotation() {
 function getLatestScoreAnnotation_NoMatch_ReturnNull() {
   describe('no matching annotation is found', () => {
     it('returns null', () => {
-      expect(service.getLatestScoreAnnotation('nodeX', 'componentX', 10, 'any')).toBeUndefined();
+      expect(service.getLatestScoreAnnotation('nodeX', 'componentX', 10, 'any')).toBeNull();
     });
   });
 }

diff --git a/src/assets/wise5/services/annotationService.ts b/src/assets/wise5/services/annotationService.ts
@@ -536,24 +536,26 @@ export class AnnotationService {
     workgroupId: number,
     scoreType: 'score' | 'autoScore' | 'any' = 'any'
   ): Annotation {
-    return this.getAnnotations()
-      .filter(
-        (annotation) =>
-          annotation.nodeId == nodeId &&
-          annotation.componentId == componentId &&
-          annotation.toWorkgroupId == workgroupId &&
-          this.matchesScoreType(annotation, scoreType)
-      )
-      .at(-1);
+    return (
+      this.getAnnotations()
+        .filter(
+          (annotation) =>
+            annotation.nodeId == nodeId &&
+            annotation.componentId == componentId &&
+            annotation.toWorkgroupId == workgroupId &&
+            this.matchesScoreType(annotation, scoreType)
+        )
+        .at(-1) || null
+    );
   }
 
   private matchesScoreType(
     annotation: Annotation,
     scoreType: 'score' | 'autoScore' | 'any'
   ): boolean {
     return (
-      ['autoScore', 'score'].includes(annotation.type) &&
-      (scoreType === 'any' || annotation.type === scoreType)
+      (scoreType === 'any' && ['autoScore', 'score'].includes(annotation.type)) ||
+      annotation.type === scoreType
     );
   }