Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(Java): Upgrade to JDK 17 #275

Merged
merged 3 commits into from
Jun 6, 2024
Merged

build(Java): Upgrade to JDK 17 #275

merged 3 commits into from
Jun 6, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

  • Upgrade Java version from 11->17. This is a necessary step to upgrade Spring Boot later.

Test Prep

  1. In WISE-Docker-Dev/docker-compose.yml, change image for wise-api service:
    • before: wiseberkeley/wise-api-dev:latest
    • after: wiseberkeley/wise-api-dev:v3

This will pull down the image that uses jdk17.

  1. Restart all Docker services for WISE

Test

  • In the log while the application starts up, verify that Java 17 and Spring Boot 2.7.18 are used:
wise-api     |   .   ____          _            __ _ _
wise-api     |  /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
wise-api     | ( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
wise-api     |  \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
wise-api     |   '  |____| .__|_| |_|_| |_\__, | / / / /
wise-api     |  =========|_|==============|___/=/_/_/_/
wise-api     |  :: Spring Boot ::               (v2.7.18)
wise-api     | 
wise-api     | 2024-05-09 18:34:03.140  INFO 84 --- [  restartedMain] o.w.Application                          : Starting Application using Java 17.0.11 on 1015c68bbdf3 with PID 84 (/app/target/classes started by root in /app)
  • Everything works as before. Test with develop branch on WISE-Client

@hirokiterashima hirokiterashima self-assigned this May 9, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review May 9, 2024 20:24
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 279f9ec into develop Jun 6, 2024
1 of 3 checks passed
@hirokiterashima hirokiterashima deleted the jdk-17 branch June 6, 2024 21:37
@geoffreykwan
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants