Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): Implement tag color #270

Merged
merged 1 commit into from
Apr 12, 2024
Merged

feat(Tag): Implement tag color #270

merged 1 commit into from
Apr 12, 2024

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Apr 11, 2024 •
edited
Loading

Changes

  • Added the ability to set color on a tag

Test prep

Run this sql query to add the color column to the user_tags table

alter table user_tags add column color varchar(25) after text;

Test

@geoffreykwan geoffreykwan self-assigned this Apr 11, 2024
@geoffreykwan geoffreykwan mentioned this pull request Apr 11, 2024
Merged
@geoffreykwan geoffreykwan marked this pull request as ready for review April 11, 2024 15:51
hirokiterashima
hirokiterashima approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit b098486 into issue-259-implement-unit-tagging Apr 12, 2024
0 of 2 checks passed
@geoffreykwan geoffreykwan deleted the implement-tag-color branch April 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @hirokiterashima