refactor(Social Login): Extract common code to abstract class #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
attemptAuthentication()
method. The functions behaves slightly differently in Google and Microsoft, and requires a change in application behavior to safely refactor. You can ignore these for now. I'll handle them in a separate task.Test Prep
?prompt=select_account
at the end ofmicrosoft.userAuthorizationUri
property. This will make you select the Microsoft account each time you login. It adds an additional click, but it prevents issues when you're signed in as another MS user but want to sign in as a different MS user for WISE.Test (with Google account and Microsoft account)
Verify that these work as before: