Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(User): Change role to roles #258

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Feb 26, 2024

Changes

  • Changed the /api/user/info endpoint to return roles string array instead of role string

Test

Closes #257

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works. I'm wondering if getRoles() should be a method in the User class for better encapsulation?

@geoffreykwan
Copy link
Member Author

Yea that's a good idea. I've moved the getRoles() function to the User class.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 6e84932 into develop Feb 29, 2024
1 of 3 checks passed
@geoffreykwan geoffreykwan deleted the issue-257-change-role-to-roles branch February 29, 2024 16:05
@geoffreykwan
Copy link
Member Author

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(User): Change role to roles
2 participants