-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Run): Allow teachers to archive runs #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments inline. It'd be good to not introduce unused methods with this PR.
...main/java/org/wise/portal/presentation/web/controllers/archive/ArchiveProjectController.java
Outdated
Show resolved
Hide resolved
...main/java/org/wise/portal/presentation/web/controllers/archive/ArchiveProjectController.java
Outdated
Show resolved
Hide resolved
...main/java/org/wise/portal/presentation/web/controllers/archive/ArchiveProjectController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/service/usertags/impl/UserTagsServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Added endpoints to
Created tables user_tags and acl_object_identity_to_user_tags tables. Run these database queries to create the tables.
Modified acl_object_identity table. Run these database queries to apply the changes.
Test
Closes #224