Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for _unfencedTop navigation target. #200

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

VergeA
Copy link
Collaborator

@VergeA VergeA commented Nov 11, 2024

This is a rewrite of #174, converting the rough outline for the _unfencedTop navigation target spec into a formal patch.


Preview | Diff

@VergeA VergeA requested a review from blu25 November 11, 2024 20:58
blu25
blu25 previously requested changes Nov 12, 2024
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one tiny tiny comment!

spec.bs Outdated Show resolved Hide resolved
@VergeA VergeA dismissed blu25’s stale review November 21, 2024 15:23

I resolved all the requested changes in other comment threads.

Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@domfarolino domfarolino merged commit 01161ae into WICG:master Nov 21, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 21, 2024
SHA: 01161ae
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@VergeA VergeA deleted the unfencedtop branch November 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants