-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Clean up + fix outdated navigation references #181
Conversation
Other algorithms in our spec, or in HTML? The current declaration of that algorithm seems pretty good / clear, what's wrong with it? |
Most algorithms in our spec don't start with "Create a new algorithm called X..." but instead either just define the algorithm's name or state "To do X given Y, run these steps:". I think it's better for this algorithm to try to match the latter for consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some new rebase conflicts, can you resolve them?
SHA: eae30ee Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The navigate algorithm has changed since we originally monkey patched it. This PR updates our monkey patch to reference the steps as they currently exist. This also cleans up the
Should navigation response to navigation request be blocked by Permissions Policy?
definition to match the formatting of other algorithms.See issue: #179
Preview | Diff