Skip to content

Commit

Permalink
More changelog detail
Browse files Browse the repository at this point in the history
  • Loading branch information
multimeric committed Sep 6, 2024
1 parent a494f6d commit 520f669
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Changed

* Files are now downloaded into the appropriate subdirectory. For example if you upload `parent/child.txt`, and then later download that file, the `parent` subdirectory will be created.
* `FileSenderClient.download_file` now has some additional args: `file_size` and `file_name` which will enable better functionality if provided. They are typically obtained from `FileSenderClient._files_from_token`
* All terminal output is now through the `logging` module. You can use the new `--log-level` CLI parameter to configure the amount of info that is printed out.
* Update the CLI default concurrency to 2 for chunks and 1 for files. This seems to be moderately performant without ever failing

Expand Down
2 changes: 0 additions & 2 deletions filesender/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,6 @@ async def download_files(
"""
Downloads all files for a transfer.
Note that currently the directory hierarchy won't be preserved. So if the original user uploaded `dir_a/file_a.txt` and `dir_b/file_b.txt`, they will simply be downloaded as `file_a.txt` and `file_b.txt` with their directories stripped out. This is a limitation of the current API. See https://github.com/filesender/filesender/issues/1555 for context.
Params:
token: Obtained from the transfer email. The same as [`GuestAuth`][filesender.GuestAuth]'s `guest_token`.
out_dir: The path to write the downloaded files.
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ dev = [
"pandas",
"jupyter",
"notebook<7",
"nbconvert"
"nbconvert",
"jupyter_contrib_nbextensions"
]

[project.scripts]
Expand Down

0 comments on commit 520f669

Please sign in to comment.