-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows for codeql and component testing #350
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Note that the checks executed as part of this PR are exactly the ones that are proposed.
@anbo-de @Perevalov |
Code scanning with CodeQL has been removed from this PR again. |
Live tests are no longer executed as part of the workflow |
Seems like because there is no more space left, not all packages can be installed while testing python components. This of course means the tests fail.
SOLVED by adding a cleanup step after tests. |
The Python tests script is taking a long time to run, compared to the one for Java components. I assume this is because of the re-installation of the requirements with pip (since the environment is created new for every component). Is there a better way to handle this? I avoided a shared environment, mainly because it allows "laziness" when defining the individual requirement files for components. EDIT |
@@ -0,0 +1,19 @@ | |||
#!/bin/bash | |||
# clone Qanary pipeline | |||
git clone https://github.com/WDAqua/Qanary.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heinpa Seems to be not required anymore due to the Qanary packages stored at Maven repository, now.
if mkdir environments; then | ||
echo "External environment directory created" | ||
else | ||
echo "External environment directory could not be created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heinpa Should there be a exit
here to stop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heinpa Looks very good. Just minor changes. See comments.
@anbo-de requested changes have been added and subshell for building Qanary dependencies locally was removed. There are now also exclusions for submodules: TEST and BUILD:
DEPLOY:
|
Execute Java and Python component tests whenever a new PR is made to the master branch.
This should check that code changes do not change the intended behaviour or that tests were updated to reflect the new functionality.
These tests would also reveal if component updates depend on external updates to the Qanary repository (like commons). They would fail if some components depend on changes to Qanary, that have not yet made it into the main branch.
A GitHub action ensures that the tests are executed at least once before changes are merged into the main branch.
Execute CodeQL for every new PR and push to master branch.