Add responseHeaders to the data object when upload is completed #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add responseHeaders to CompletedData type.
Add responseHeaders for iOS
Add iOS support for responseHeaders
siiiiilvio
changed the title
|
Any chance this gets merged? Needed for multipart uploads to an S3 bucket on iOS. Seems to already work on android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using your this library with your own multipart uploader, you may need some additional information from the response such as Etag headers from Amazon S3.
Test Plan
When the response is valid, populate the responseHeaders with the response headers using allHeaderFields.
What's required for testing (prerequisites)?
Test completed, cancelled and error scenarios.
What are the steps to reproduce (after prerequisites)?
When upload is completed, inspect the data object with the nested responseHeaders object.
Compatibility
| iOS | ✅
| Android | ✅ (Already implemented by #265)
Checklist
README.md