Skip to content

Commit

Permalink
update package, provide a repro for failign SSR import
Browse files Browse the repository at this point in the history
  • Loading branch information
eric-burel committed Jun 24, 2020
1 parent ec84f6d commit 3589018
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .meteor/packages
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ [email protected]
# accounts-facebook

vulcan:debug
# To run the backoffice
vulcan:backoffice
vulcan:accounts
# Ui
vulcan:ui-bootstrap
# vulcan:ui-material

meteortesting:mocha
apollo
5 changes: 3 additions & 2 deletions packages/vulcan-backoffice/lib/components/BackofficeIndex.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import React from 'react';
import { Components, registerComponent } from 'meteor/vulcan:core';
import NoSSR from 'react-no-ssr';

const BackofficeIndex = () => (
const BackofficeIndex = () => {
return (
<div>
<p>Welcome to Vulcan autogenerated backoffice</p>
{/** AccountsLoginForm is SSR only */}
Expand All @@ -12,7 +13,7 @@ const BackofficeIndex = () => (
</NoSSR>
</div>
</div>
);
);};
registerComponent({ name: 'VulcanBackofficeIndex', component: BackofficeIndex, hocs: [] });

export default BackofficeIndex;
2 changes: 1 addition & 1 deletion packages/vulcan-backoffice/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Package.describe({
});

Package.onUse(api => {
api.use(['vulcan:core@=1.15.1', 'vulcan:i18n@=1.15.1']);
api.use(['vulcan:core@=1.15.1', 'vulcan:i18n@=1.15.1', 'vulcan:[email protected]']);

api.mainModule('lib/server/main.js', 'server');
api.mainModule('lib/client/main.js', 'client');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import IconButton from '@material-ui/core/IconButton';
import MenuIcon from 'mdi-material-ui/Menu';
import { Link } from 'react-router-dom';

const BackofficeNavbar = ({ onClick, basePath }) => (
const BackofficeNavbar = ({ onClick, basePath }) => {
// console.log('Icon render', MenuIcon); // @see https://github.com/VulcanJS/Vulcan/issues/2580
return (
<AppBar position="static">
<Toolbar>
<IconButton edge="start" color="inherit" aria-label="menu" onClick={onClick}>
Expand All @@ -19,6 +21,6 @@ const BackofficeNavbar = ({ onClick, basePath }) => (
</Link>
</Toolbar>
</AppBar>
);
);};

registerComponent('VulcanBackofficeNavbar', BackofficeNavbar);

0 comments on commit 3589018

Please sign in to comment.