Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ui-bootstrap to starter packages #57

Closed
wants to merge 1 commit into from
Closed

added ui-bootstrap to starter packages #57

wants to merge 1 commit into from

Conversation

JstnEdr
Copy link

@JstnEdr JstnEdr commented May 11, 2018

When starting many of the starter packages, an error was popping "'toLowerCase' of undefined". I'm pretty sure this is related to issue #50 and/or issue #51. I simply included 'vulcan:[email protected]' in the package.json files for each package and they now seem to be working properly.

@kabalin
Copy link
Contributor

kabalin commented May 11, 2018

@SachaG I was wondering if package-lock.json can be added to .gitignore, or it needs to be supplied for some reason?

@SachaG
Copy link
Contributor

SachaG commented May 13, 2018

Oh thanks, I completely overlooked that. I'll probably fix it myself directly to avoid merging the package-lock.json file.

@kabalin I'm not sure to be honest, having it committed ensures everybody is running the same packages I guess?

@SachaG SachaG closed this May 13, 2018
@kabalin
Copy link
Contributor

kabalin commented May 13, 2018

@SachaG you are right re package-lock.json, more info is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants