-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help wanted: update starter packages for new ui-bootstrap package #50
Comments
Since the dropdown component is probably the most complex to port, here is an example from zenshome.jp:
|
Oh and feel free to also submit PRs back to the core repo to improve the |
I'll probably work on this myself since there are no takers. Also a good chance to review/clean up the Forum code generally. |
I was going to take it. In fact I have done it partly. |
Moving away of direct react-bootstrap dependency (issue VulcanJS#50).
Moving away of direct react-bootstrap dependency (issue VulcanJS#50).
Oh in that case please do! I haven't actually started on this :) |
Moving away of direct react-bootstrap dependency (issue VulcanJS#50). Patch dos not include Dropdown and Modal refactoring yet.
@SachaG yep, will do in that case, it is a good excercise for me :) |
Moving away of direct react-bootstrap dependency (issue VulcanJS#50).
Moving away of direct react-bootstrap dependency (issue VulcanJS#50).
Moving away of direct react-bootstrap dependency (issue VulcanJS#50). Patch dos not include Dropdown and Modal refactoring yet.
Moving away of direct react-bootstrap dependency (issue VulcanJS#50).
There was an error coming up for many of the starter packages that were missing an import in the |
Goal: remove all dependencies on
react-bootstrap
from Starter repoThe example packages currently rely a lot on Bootstrap in the form of dependencies on
react-bootstrap
. But we can now get rid of this dependency by replacing all Bootstrap components with their equivalent Vulcan component.In other words,
<Button/>
imported fromreact-bootstrap
becomes<Components.Button/>
; which in turn can call a Bootstrap, Material, Semantic, etc. component according to which UI package is currently active.You can see all currently available components here.
TODO:
react-bootstrap
throughout the Starter repo.The text was updated successfully, but these errors were encountered: