Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parry update simpler traverse #2

Open
wants to merge 8 commits into
base: parry_update
Choose a base branch
from
Open

Parry update simpler traverse #2

wants to merge 8 commits into from

Conversation

Vrixyz
Copy link
Owner

@Vrixyz Vrixyz commented Dec 4, 2024 •
edited
Loading

  • builds on top of parry next version (0.18.x) dimforge/rapier#763 to use traverse_depth_first within intersection_with_shape.
  • This is not testable as-is because it needs a small update from parry to support visitor.found_intersection, which is a controversial change.

See following trace with example 2d 100 x 100 balls:

  • 🟨 this trace is master (traverse_best_first)
  • 🟥 external trace is this PR (traverse_depth_first)

image

@Vrixyz Vrixyz force-pushed the parry_update-simpler_traverse branch from 5a3b8bf to 4574167 Compare December 5, 2024 15:29
@Vrixyz Vrixyz force-pushed the parry_update-simpler_traverse branch from ae9f49c to 3173aa8 Compare December 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrixyz @legendofa