Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create countries bubble chart #451

Merged

Conversation

barbara-chaves
Copy link
Contributor

This PR created the countries bubble chart

Design

Testing

Go to '/ascor'
The bubble chart should be displayed

@barbara-chaves barbara-chaves added the javascript Pull requests that update Javascript code label Oct 4, 2023
@barbara-chaves barbara-chaves self-assigned this Oct 4, 2023
Copy link
Collaborator

@martintomas martintomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;). There are just two things which I have discovered:

  • the most serious is that market_cap_group is not taken into account --> size of the bubble is always same, it should depend on it
  • console is full of some errors such as Chart.js:36 WRONG INDEX {pillar: 'Climate Finance', area: 'Renewable Opportunities', result: null, country_id: 15, country_name: 'Thailand', …}
  • also PR contains code for Companies Accordion, but I don't think it is used anywhere <-- if it is true, better to remove it now

@barbara-chaves
Copy link
Contributor Author

Looks good to me ;). There are just two things which I have discovered:

  • the most serious is that market_cap_group is not taken into account --> size of the bubble is always same, it should depend on it
  • console is full of some errors such as Chart.js:36 WRONG INDEX {pillar: 'Climate Finance', area: 'Renewable Opportunities', result: null, country_id: 15, country_name: 'Thailand', …}
  • also PR contains code for Companies Accordion, but I don't think it is used anywhere <-- if it is true, better to remove it now

@martintomas
I added the market_cap_group scales, but it might need tweaking when it comes to the real data
I have nothing in my console, but it looks like the data you have is different from mine (you have 'result: null' in your data)
I deleted the Companies Accordion component

@martintomas martintomas merged commit 4990e5c into develop Oct 5, 2023
3 checks passed
@martintomas martintomas deleted the client/feature/LSE-124-fe-bubble-chart-for-countries branch October 24, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants