-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mq scores - DONT MERGE #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Bluesmile82 for this. I have checked it and looks great! There are just two minor issues that I have discovered:
Popup -- not sure if this is worthy of fix or can be ignored
- go to All sectors and select Beta data
- click on Proceed
- select Aluminium from drop sector drop down
- you are again presented with popup, because BETA data are still picked option -- find it a bit strange. Can understand that it is because I have not picked
dont show again
option, but still I probably don't wanna see popup again just because I have selected different sector
Nr of assessments: 5 graph
- go to Rio Tinto (Aluminium) company and select BETA data
- set Assessment date next to
Management Quality: Rio Tinto (Aluminium)
onto 09 July 2022 (click on this option again if it is already selected) - change MQ methodology to Current again
- you will end up with this bug
Also 5 [BETA]
level should probably not be visible at this graph when Current
MQ methodology is picked
Lets merge this to dev branch so this stuff can be presented to client on Friday at Stage server. Meanwhile I have merged all current stuff related to Bank CP from dev to master so this can be deployed to Prod (will do so tomorrow morning). In case that we will need to push some Bank CP stuff to Prod at future (hotfix, tweak of something, etc.), It can be cherry picked to master or merged directly so master so we still can push stuff to Prod, but don't deploy this code to Prod for now. |
DONT MERGE YET!