Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mq scores - DONT MERGE #431

Merged
merged 13 commits into from
Aug 16, 2023
Merged

Feature/mq scores - DONT MERGE #431

merged 13 commits into from
Aug 16, 2023

Conversation

Bluesmile82
Copy link
Collaborator

@Bluesmile82 Bluesmile82 commented Aug 14, 2023

DONT MERGE YET!

  • Add a react modal that shows when the level 5 is active. It can be dismissed and also has a 'Don't show again button'
  • Change Level 5 to Level 5 [BETA] in some charts
  • Make level 5 data show in some charts

@Bluesmile82 Bluesmile82 added ruby Pull requests that update Ruby code javascript Pull requests that update Javascript code labels Aug 14, 2023
@Bluesmile82 Bluesmile82 changed the title Feature/mq scores Feature/mq scores - DONT MERGE Aug 14, 2023
Copy link
Collaborator

@martintomas martintomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bluesmile82 for this. I have checked it and looks great! There are just two minor issues that I have discovered:
Popup -- not sure if this is worthy of fix or can be ignored

  • go to All sectors and select Beta data
  • click on Proceed
  • select Aluminium from drop sector drop down
  • you are again presented with popup, because BETA data are still picked option -- find it a bit strange. Can understand that it is because I have not picked dont show again option, but still I probably don't wanna see popup again just because I have selected different sector

Nr of assessments: 5 graph

  • go to Rio Tinto (Aluminium) company and select BETA data
  • set Assessment date next to Management Quality: Rio Tinto (Aluminium) onto 09 July 2022 (click on this option again if it is already selected)
  • change MQ methodology to Current again
  • you will end up with this bug
Screenshot 2023-08-15 at 12 39 39

Also 5 [BETA] level should probably not be visible at this graph when Current MQ methodology is picked

@martintomas
Copy link
Collaborator

Lets merge this to dev branch so this stuff can be presented to client on Friday at Stage server. Meanwhile I have merged all current stuff related to Bank CP from dev to master so this can be deployed to Prod (will do so tomorrow morning). In case that we will need to push some Bank CP stuff to Prod at future (hotfix, tweak of something, etc.), It can be cherry picked to master or merged directly so master so we still can push stuff to Prod, but don't deploy this code to Prod for now.
FYI @Bluesmile82

@martintomas martintomas merged commit b877d51 into develop Aug 16, 2023
3 checks passed
@martintomas martintomas deleted the feature/mq-scores branch October 24, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants