Review fixes

Vizzuality · Oct 5, 2023 · 6e09a32 · 6e09a32
1 parent d7230fb
commit 6e09a32
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 163 deletions.
diff --git a/app/javascript/components/tpi/charts/ascor-bubble/Chart.js b/app/javascript/components/tpi/charts/ascor-bubble/Chart.js
@@ -4,6 +4,15 @@ import SingleCell from './SingleCell';
 
 import { SCORE_RANGES } from './constants';
 
+const SCALE = 1.25;
+
+// radius of bubbles
+const COMPANIES_MARKET_CAP_GROUPS = {
+  large: 10 * SCALE,
+  medium: 5 * SCALE,
+  small: 3 * SCALE
+};
+
 const SINGLE_CELL_SVG_WIDTH = 120;
 const SINGLE_CELL_SVG_HEIGHT = 100;
 
@@ -157,7 +166,7 @@ const createRow = (dataRow, area, pillars, disabled_bubbles_areas) => {
         const countriesBubbles = disabled_bubbles_areas.includes(area)
           ? []
           : el.map((result) => ({
-            value: 10,
+            value: COMPANIES_MARKET_CAP_GROUPS[result.market_cap_group],
             tooltipContent: {
               header: result.country_name,
               value: result.result

diff --git a/app/javascript/components/tpi/charts/ascor-bubble/CompaniesAccordion.js b/app/javascript/components/tpi/charts/ascor-bubble/CompaniesAccordion.js
diff --git a/app/javascript/components/tpi/charts/ascor-bubble/index.js b/app/javascript/components/tpi/charts/ascor-bubble/index.js
@@ -1,4 +1,3 @@
 import Chart from './Chart';
-import CompaniesAccordion from './CompaniesAccordion';
 
-export {Chart, CompaniesAccordion};
+export { Chart };