Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: collapse PosRot cfg within the struct #5

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

the cfg flags on the PosRot struct can be moved onto specific methods of the implementation block, instead of duplicating the entire block between the glam and not(glam) features

leaving as a draft, for discussion

@danieleades danieleades force-pushed the experiment.PosRot-refactor branch from 6f77248 to 7bf17b3 Compare October 20, 2024 18:03
@VirxEC
Copy link
Owner

VirxEC commented Oct 20, 2024

I did [f32; 3] as it guarantees that PosRot is 12 bytes. If this causes no perf regressions and makes implementing stuff like #6 easier, then I'd be down for this change.

@danieleades
Copy link
Contributor Author

i guess it must still be 12 bytes or that test would be failing

@danieleades
Copy link
Contributor Author

there's probably further optimisation that can be done here if including nalgebra, since PosRot is roughly equivalent to nalgebra's Isometry2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants