Add superagent request builder #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2016 09:36
- Change TestHelper to use new RequestBuilder
lib/utils/multi-require-js exports a function..
elhigu
reviewed
Sep 29, 2016
| @@ -1,4 +1,5 @@ | |||
| module.exports = { | |||
| RangeParser: require('./range-parser').RangeParser, | |||
| request: require('./request') | |||
| request: require('./request'), | |||
| requestBuilder: require('./request-builder').requestBuilder | |||
There was a problem hiding this comment.
I had thought to put this under util and drop the http directory completely. So there would be 2 different request modules at the same time so that people can easily migrate deprecated requests calls to new ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to change some imports for dodo-core-features and dodo-starterkit.
Dodo.js should be released to npm with these changes so dodo-core-features and dodo-starterkit can be fixed.