add missing use and fix some phpdoc and phpcs

Victoire · Oct 7, 2016 · 0d4aa3c · 0d4aa3c
1 parent 0316b96
commit 0d4aa3c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/Bundle/FormBundle/Helper/FormErrorHelper.php b/Bundle/FormBundle/Helper/FormErrorHelper.php
@@ -2,6 +2,8 @@
 
 namespace Victoire\Bundle\FormBundle\Helper;
 
+use Symfony\Component\Form\Form;
+
 /**
  * A service that give errors from a form as a string.
  *

diff --git a/Bundle/WidgetBundle/Entity/Widget.php b/Bundle/WidgetBundle/Entity/Widget.php
@@ -534,12 +534,6 @@ public function generateCacheId()
             throw new \Exception(sprintf('Cannot generate an hash for widget %s if currentView is not defined.',
                 $this->getId()
             ));
-            if (!$this->getCurrentView()->getReference()) {
-                throw new \Exception(sprintf('Cannot generate an hash for widget %s if currentView %s Reference is not defined.',
-                    $this->getId(),
-                    $widget->getCurrentView()->getId()
-                ));
-            }
         }
 
         return sprintf('%s-%s-%s',
@@ -558,7 +552,7 @@ public function getLocale($defaultLocale)
     {
         if ($this->hasCriteriaNamed('locale')) {
             foreach ($this->getCriterias() as $criteria) {
-                if ($criteria->getName() === 'locale' &&  $criteria->getValue() === $defaultLocale) {
+                if ($criteria->getName() === 'locale' && $criteria->getValue() === $defaultLocale) {
                     return $criteria->getValue();
                 }
             }

diff --git a/Tests/Functionnal/app/AppKernel.php b/Tests/Functionnal/app/AppKernel.php
@@ -72,7 +72,9 @@ public function registerBundles()
         ];
     }
 
-
+    /**
+     * @param LoaderInterface $loader
+     */
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
         $loader->load(__DIR__.'/config/config_'.$this->getEnvironment().'.yml');
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,8 @@ @@
     namespace Victoire\Bundle\FormBundle\Helper;
+    use Symfony\Component\Form\Form;
     /**
      * A service that give errors from a form as a string.
      *
@@ Expand Down @@