Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow generated logs to have unique hostnames #29

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Aug 28, 2023

This PR changes the generator to append a random integer to the hostname value in the log message in order to ensure uniqueness of the field.

cc: @jcantrill

@Red-GV Red-GV force-pushed the unique-log-names branch 2 times, most recently from 882cd1a to 0c20a90 Compare August 28, 2023 13:51
@xperimental
Copy link
Contributor

xperimental commented Aug 28, 2023

@Red-GV I think you found a bug in the docker workflow ... fixing ...

edit: the issue is fixed in main now, so merging/rebasing should fix this PR as well. Unfortunately it still tries to use the configuration from this PR.

main.go Outdated Show resolved Hide resolved
@jcantrill
Copy link
Member

wfm

@xperimental xperimental merged commit f827287 into ViaQ:main Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants