Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JAVA 11 #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compatibility with JAVA 11 #115

wants to merge 1 commit into from

Conversation

gerw
Copy link

@gerw gerw commented Mar 24, 2019

Currently, the profile editor does not run under JAVA 11. I have added some libraries related to JAXB as dependencies and now it works fine with newer versions of JAVA (at least under linux, I did not test other OS).

Otherwise, the application will not run with JAVA 11.
@Vhati
Copy link
Owner

Vhati commented Mar 25, 2019

On it! Thanks for letting me know. =)

I'll have to make some other changes. The JAXB dependency requires Java 7, so all my nods to Java 6 compatibility need to be raised. Plus Maven's repo servers migrated to TLS 1.2, which raised the minimum build environment to Java 7 anyway. WinXP will require SP2 to run Java 7.

@gerw
Copy link
Author

gerw commented Mar 25, 2019

Thank you for your reply. I somehow expected that this is not enough.

To be honest, I do not now anything about JAVA and I just wanted to use the FTL editor :)

@jryski
Copy link

jryski commented Aug 13, 2020

Currently, the profile editor does not run under JAVA 11. I have added some libraries related to JAXB as dependencies and now it works fine with newer versions of JAVA (at least under linux, I did not test other OS).

I've been trying to figure out how to do this on ubuntu 20.08... java 11 is basically all that's available, and I've installed maven, but I can't find where you've made these changes, nor can I get maven to build this.

I'm new to git, trying to learn by starting with something I enjoy rather than dry textbook material.

@EgorBodnar
Copy link

Good job, @gerw !
Rise the JDK version to 1.7, please. You couldn't build on the 1.6, it is not supported.
I've tested it, works well! Good to merge!

@timelessthee
Copy link

timelessthee commented May 9, 2021

Awesome! Is there a chance of getting an updated compiled binary that works?

@Forceu
Copy link

Forceu commented Jun 24, 2021

I forked this PR and released a compiled binary: https://github.com/Forceu/ftl-profile-editor/releases/tag/v28-java11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants