[VAN-545] extract loop body to separate function before unrolling #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
changed the title
tim-hoffman
changed the title
Needed to allow certain fields to be mutated during the run/execute visitor pattern that previously required a borrow on the entire PassMemory object.
…cmp counter also a few minor rust warning fixes and code cleanup
tim-hoffman
force-pushed
the
th/loop-body-extraction
branch
from
29792e1
to
678c9eb
Compare
add additional test (that happened to need this)
tim-hoffman
changed the title
0xddom
reviewed
Oct 11, 2023
0xddom
requested changes
Oct 11, 2023
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
Comment on lines
90
to
107
| let get_ptr = || { | ||
| let arr_ptr = match &self.address_type { | ||
| AddressType::Variable => producer.body_ctx().get_variable_array(producer), | ||
| AddressType::Signal => producer.template_ctx().get_signal_array(producer), | ||
| AddressType::SubcmpSignal { cmp_address, counter_override, .. } => { | ||
| let addr = cmp_address.produce_llvm_ir(producer) | ||
| .expect("The address of a subcomponent must yield a value!"); | ||
| if *counter_override { | ||
| return producer.template_ctx().load_subcmp_counter(producer, addr) | ||
| } else { | ||
| let subcmp = producer.template_ctx().load_subcmp_addr(producer, addr); | ||
| create_gep(producer, subcmp, &[zero(producer)]) | ||
| } | ||
| } | ||
| }; | ||
| pointer_cast(producer, arr_ptr.into_pointer_value(), array_ptr_ty(producer)) | ||
| }; | ||
| create_call(producer, name.as_str(), &[get_ptr().into(), index.into()]) |
There was a problem hiding this comment.
So I could do an early return for the counter_override case :)
|
And sorry for 29 comments all of a sudden |
0xddom
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.