Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAN-1446] use vector values in interpreter to properly handle vector returns #142

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[VAN-1446] use vector values in interpreter to properly handle vector returns #142

merged 3 commits into from
Jul 30, 2024

Conversation

tim-hoffman
Copy link

No description provided.

iangneal
iangneal approved these changes Jul 30, 2024
View reviewed changes
Copy link

@iangneal iangneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. If I understand correctly, this shouldn't impact ZK Vanguard's analysis, should it? I couldn't determine if there should be any differences in the generated IR.

@tim-hoffman
Copy link
Author

Code LGTM. If I understand correctly, this shouldn't impact ZK Vanguard's analysis, should it? I couldn't determine if there should be any differences in the generated IR.

Not directly. It just makes the internal interpreter more accurate in the presence of function calls so it would compute fewer unknowns and ideally optimize further in some situations.

@tim-hoffman tim-hoffman merged commit ccaa1c1 into llvm Jul 30, 2024
3 checks passed
@tim-hoffman tim-hoffman deleted the th/VAN-1446-B branch July 30, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iangneal iangneal iangneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-hoffman @iangneal