More flexible and consistent matching patterns in tests #134

tim-hoffman · 2024-07-11T18:56:08Z

Will soon be making changes that require more flexibility in the names of generated functions.
Changes to variable name matching make it consistent across files and use the . properly in matches.

iangneal

Shall we start a gofundme so we can replace your backslash key?

circom/tests/constraints/missed_index_simpl.circom

tim-hoffman · 2024-07-11T20:01:05Z

Shall we start a gofundme so we can replace your backslash key?

Haha, don't worry, it was mainly find-replace.

tim-hoffman added 3 commits July 11, 2024 13:05

Escape the period in match patterns

a119e8e

more flexibility when matching generated function names

b20c2a2

flexible naming for function local variables

a8974f5

tim-hoffman requested review from iangneal and 0xddom July 11, 2024 18:56

iangneal approved these changes Jul 11, 2024

View reviewed changes

circom/tests/constraints/missed_index_simpl.circom Outdated Show resolved Hide resolved

tim-hoffman added 7 commits July 11, 2024 15:04

rename file

e5c104f

Update regex for "array.param" functions

3469da2

Make source function regex patterns flexible

9307962

add run function opening brackets

5a21ed7

use regex matches in more test cases

197e913

Use more regex for tests in calls and controlflow directories

b1adc0b

replace remaining "arena" locals with regex variable

dbbb11d

0xddom approved these changes Jul 12, 2024

View reviewed changes

tim-hoffman merged commit a838a8d into llvm Jul 12, 2024
2 checks passed

tim-hoffman deleted the th/test-outputs branch July 12, 2024 19:28

Provide feedback