Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vcert dependency #42

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Update vcert dependency #42

merged 4 commits into from
Nov 9, 2023

Conversation

rvelaVenafi
Copy link
Contributor

No description provided.

@rvelaVenafi
fix(private-key): Fixes an issue with csr origin service and private …
86a3f1f 
…key types

Fixes an issue whereby setting csr_origin to SERVICE ignored the private key type and size/curve. This caused all service generated CSR's to use RSA 2048 as default key type.
@rvelaVenafi rvelaVenafi merged commit 4ee9549 into main Nov 9, 2023
3 of 4 checks passed
@rvelaVenafi rvelaVenafi deleted the update_vcert_dependency branch November 9, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbanic-venafi sbanic-venafi sbanic-venafi approved these changes

@luispresuelVenafi luispresuelVenafi luispresuelVenafi approved these changes

@marcos-albornoz marcos-albornoz Awaiting requested review from marcos-albornoz marcos-albornoz is a code owner

@EduardoVV EduardoVV Awaiting requested review from EduardoVV EduardoVV is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvelaVenafi @luispresuelVenafi @sbanic-venafi