Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to idb-rs 0.1.4 #5989

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/examples/idb_import/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ edition = "2021"
crate-type = ["cdylib"]

[dependencies]
anyhow = "1.0.86"
anyhow = { version = "1.0.86", features = ["backtrace"] }
binaryninja = { path = "../../" }
idb-rs = { git = "https://github.com/Vector35/idb-rs", rev = "ce943e1" }
idb-rs = { git = "https://github.com/Vector35/idb-rs", version = "0.1.4" }
log = "0.4.20"
57 changes: 57 additions & 0 deletions rust/examples/idb_import/src/addr_info.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
use std::collections::HashMap;

use anyhow::Result;

use idb_rs::id0::ID0Section;
use idb_rs::til;

#[derive(Default)]
pub struct AddrInfo<'a> {
// TODO does binja diferenciate comments types on the API?
pub comments: Vec<&'a [u8]>,
pub label: Option<&'a str>,
// TODO make this a ref
pub ty: Option<til::Type>,
}

pub fn get_info(id0: &ID0Section, version: u16) -> Result<HashMap<u64, AddrInfo<'_>>> {
let mut addr_info: HashMap<u64, AddrInfo> = HashMap::new();

// the old style comments, most likely empty on new versions
let old_comments = id0.functions_and_comments()?.filter_map(|fc| {
use idb_rs::id0::FunctionsAndComments::*;
match fc {
Err(e) => Some(Err(e)),
Ok(Comment { address, comment }) => Some(Ok((address, comment))),
Ok(Name | Function(_) | Unknown { .. }) => None,
}
});
for old_comment in old_comments {
let (addr, comment) = old_comment?;
let comment = comment.message();
addr_info.entry(addr).or_default().comments.push(comment);
}

// comments defined on the address information
for info in id0.address_info(version)? {
use idb_rs::id0::AddressInfo::*;
let (addr, info) = info?;
let entry = addr_info.entry(addr).or_default();
match info {
Comment(comments) => entry.comments.push(comments.message()),
Label(name) => {
if let Some(_old) = entry.label.replace(name) {
panic!("Duplicated label for an address should be impossible this is most likelly a programing error")
}
}
TilType(ty) => {
if let Some(_old) = entry.ty.replace(ty) {
panic!("Duplicated type for an address should be impossible this is most likelly a programing error")
}
}
Other { .. } => {}
}
}

Ok(addr_info)
}
Loading
Loading