Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.lock #5791

Closed
wants to merge 2 commits into from
Closed

Update Cargo.lock #5791

wants to merge 2 commits into from

Conversation

mkrasnitski
Copy link
Contributor

This PR updates dependencies in Cargo.lock in order to fix compilation with Rust 1.80 (see time-rs/time#693). in doing so, uuid v1.8.0 introduced a change which broke type inference in a few places in pdb-ng, so those places are changed to accomodate.

Also, deleted every other Cargo.lock file because they weren't actually being used. They were located inside workspace member directories, whose dependencies are tracked in the main project's Cargo.lock and so served no use. Finally, changed the patched pdb dependency from a git submodule to a cargo git-dependency.

Update `time` to v0.3.36 to fix compilation with Rust 1.80

Breaking change in `uuid` newer than v1.8.0 required code changes
@emesare
Copy link
Member

emesare commented Jul 29, 2024

We are actually going to move away from Cargo.lock entirely as its purpose is moot for any dependency (which is what the sys and wrapper crate both are), other than for tests and what not. Keeping it up-to-date is a chore and we should instead run ci on the latest possible version of a cargo dependency (that way we can catch things like uuid making a breaking change).

For anyone interested the changes will land on https://github.com/Vector35/binaryninja-api/tree/rust_break_everything for testing

@emesare emesare closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants