Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exosuit Stress Sensor QoL #716

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Exosuit Stress Sensor QoL #716

wants to merge 2 commits into from

Conversation

Dudblockman
Copy link
Member

Currently Stress Sensor will never activate if the blow would immediately reduce the caster from >6 HP to 0.
Perhaps making it able to trigger off the damage event would make it more desirable overall by enabling it to trigger on what would be a lethal blow?
Probably needs further thought but threw this together quickly to test the concept.

@Dudblockman Dudblockman requested a review from Kamefrede May 8, 2021 06:32
@Kamefrede
Copy link
Contributor

What sort of testing have you done with this?
Does it like take into consideration stuff like totems?

@Dudblockman
Made exosuit stress sensor trigger from potentially lethal damage tha…
d81f8d7 
…t would otherwise never trigger the sensor

Please factcheck this, I'm not entirely sure if the amount of damage is accurate taking armor and such into account

(cherry picked from commit d7aa2ab)
@Dudblockman
Add proper condition
012bf56 
(cherry picked from commit c11c9e1)
@Dudblockman Dudblockman marked this pull request as draft May 20, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kamefrede Kamefrede Awaiting requested review from Kamefrede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudblockman @Kamefrede