Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-4641]Provide a way to get the player's head by uuid #4770

Open
wants to merge 4 commits into
base: 1.20.x
Choose a base branch
from

Conversation

Suisuroru
Copy link

@Suisuroru Suisuroru commented Nov 30, 2024

This provide the way to get the player's head by using uuid.
It used mojang's API, please enter right uuid or user name to build the head.
Because of the uuid's head-building is based on mojang's API, if you give a fault uuid, it may cause lag now.(this is my test log,I write a unreal uuid to build the head,latest.log)

It fixed in the later commit by cache the uuid and do not load the uuid's skin for repeating times.(Suisuroru#1)

@Suisuroru Suisuroru changed the title Provide a way to get the player's head by using uuid Provide a way to get the player's head by uuid Dec 3, 2024
* Modify the GUI logic of RA to reduce lag caused by skull related issues

Start synthesis by checking to determine the result of product generation

* Fix the null pointer exception that may occur in floating text at the top of Runic Altar in certain languages

* Optimize the failure handling logic in the UUID name provider - Extract the SaveFailureData method to reduce code duplication.
@Suisuroru
Copy link
Author

I've tried to fix the lagging issue in the case of entering the wrong uuid, now both correct and incorrect uuid will only cause one peak lag on initial load instead of repeated small lags

@Suisuroru Suisuroru changed the title Provide a way to get the player's head by uuid [Issue-4641]Provide a way to get the player's head by uuid Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant