Implement vibration support #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added vibrations for: - adding or removing water/lava (via bucket or rain) - adding or removing items - crafting output item
Added vibrations for: - adding or removing items - crafting output item
Added vibrations for: - mana pool infusing item - manatide bellows blowing (both when used by a player and when boosting mana transfer speed from a pool to an item)
Added vibrations for: - adding or removing a lens
Added vibrations for: - adding or removing an incense stick - lighting the plate - burn time ending
Added vibrations for: - applying phantom ink to a luminizer - non-item entities riding the luminizer (mounting/unmounting luminizer already emits vibrations)
Added vibrations for: - applying overgrowth seed - using block breaking horns - eating from the Fruit of Grisaia - playing a mob sound with cacophonium or cacophonium block - teleporting with world seed or Eye of the Flügel - using Laputa Shard, and having it break and place blocks
Added vibrations for: - fluid pickup, and generation start/end for Hydroangeas and Thermalily (no vibration for end of cooldown) - burn start and end for Endoflame - block conversions for Orechid (Ignem) and Marimorphosis - block breaking into clay for Clayconia - block conversions for Pure Daisy - Jaded Amaranthus placing flowers - Shulk Me Not eating mobs - Munchdew eating leaves - Gourmaryllis eating an item (and burping) - Kekimurus eating cake slices
Added vibrations for: - Rod of the Hells spawning fire circle (player and avatar) - player using Rod of the Bifrost (no vibrations for blocks appearing or disappearing, or avatar using it) - player using or being boosted by Rod of the Skies - player using Rod of the Plentiful Mantle
- add vibration for breaking blocks with bore lens burst - improve game event call for HornItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes #4349 by adding vibrations to many blocks and items that didn't emit them though default logic yet.