Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xplat: Switch from VanillaGradle to minivan #4684

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

quat1024
Copy link
Contributor

@quat1024 quat1024 commented Jun 20, 2024

minivan is my Gradle plugin that acts like VanillaGradle. It is written with pretty boring straightforward code, makes no attempt to download a copy of the Minecraft assets or anything else necessary to support a runClient, and doesn't use any IntelliJ "task activations", so it's a good bit lighter weight.

Interesting: When switching, I had to manually add a dependency on jetbrains annotations. Maybe vanillagradle did that?

Also adds the foojay-resolver-convention plugin, b/c apparently I don't have Java 17 installed in a place where Gradle can find it. This is a well-known Gradle 8 upgrade woe wrt. the toolchains feature.

@TheRealWormbo
Copy link
Collaborator

Is that just a thing with the IntelliJ decompiler, or does the generated code really have @SideOnly(Side.CLIENT) on too many classes? (I also noticed that before this update with access widening.)

@quat1024
Copy link
Contributor Author

Hm, interesting, might be a failure of the jar merging.

Which classes?

@TheRealWormbo
Copy link
Collaborator

So far I've noticed it on any entity class I checked, including ServerPlayer. It might just be all classes, including nested ones. Unfortunately IntelliJ likes to navigate to Fabric versions of classes (presumably because those have configured sources), which is making this a bit harder to check.

@quat1024
Copy link
Contributor Author

quat1024 commented Jun 20, 2024

Well that's embarrassing, I forgot to unbundle the server jar. Glad i didn't publish 0.5 yet >.>

Should be fixed in the latest minivan snapshot (commit hash c5ae507).

@TheRealWormbo
Copy link
Collaborator

Yup, looks better.

go go gadget github web editor
@artemisSystem
Copy link
Member

Tested a bit and it seems to work just fine. Thanks a lot!

@artemisSystem artemisSystem merged commit 888272e into VazkiiMods:1.20.x Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants