Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage type datagen fix #4683

Merged
merged 6 commits into from
Jun 23, 2024
Merged

Conversation

BrokenK3yboard
Copy link
Contributor

Fix datagen for damage types, manually writing entries should no longer be necessary.

Copy link
Collaborator

@TheRealWormbo TheRealWormbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the FabricDynamicProvider class could use a better name that describes what it's actually used for. Otherwise looking good to me.

@BrokenK3yboard
Copy link
Contributor Author

BrokenK3yboard commented Jun 22, 2024

It's extended from FabricDynamicRegistryProvider and is meant to register multiple different types. Enchantments and Enchantment providers need to be registered there as well for them to be generated (At least in 1.21) among other things, so I don't have any clear-cut name in mind.

@TheRealWormbo
Copy link
Collaborator

It's just that the class name itself says even less about what it's supposed to do than its parent class.
So as far as I understand, it fills dynamic registries with data relevant to Botania's datagen run. How about BotaniaDynamicRegistryProvider, then?

@BrokenK3yboard
Copy link
Contributor Author

Sounds fine to me.

@TheRealWormbo TheRealWormbo merged commit 49f1217 into VazkiiMods:1.20.x Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants