Improvements to The Spectator #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes both block entities and container minecarts with a loot table that has not yet been unpacked. Unfortunately, instanced Lootr containers and minecarts will always be skipped now. (fixes VazkiiMods#4567)
- Scanning only happens every 4 game ticks - Scanning for both potential held items in a single pass - Entity scan does not check non-item entities if player is not holding any items, but is pressing shift - Block scan is skipped entirely if player is not holding any items - Block positions are stored as long-type array tag instead of list tag with long tag entries - Scan results are cleared when the Spectator becomes unequipped (fixes VazkiiMods#3500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(still no support for per-player inventories, such as ender chests or opened Lootr containers)