Pollidisiac feeds flowers to brown mooshrooms #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break; | ||
| // Note: Empty item stacks are implicitly excluded in Animal::isFood and ItemStack::is(TagKey) | ||
| if (!animal.isInLove()) { | ||
| for (ItemEntity item : items) { |
There was a problem hiding this comment.
I'm not quite sure this works as intended. Won't this consume multiple items on one animal? There's nothing that breaks out of the loop once a food item has been consumed from what i can see.
There was a problem hiding this comment.
Good point, that item loop was definitely missing a break.
artemisSystem
requested changes
Dec 30, 2023
Also includes smaller optimizations to the finding and feeding logic: * don't look for anything if out of mana * exclude items from the search that can't be interacted with * don't look for animals when no items are around * exclude animals from the search that would not be fed anyway because they are a baby, or already in the mood and not a brown mooshroom
TheRealWormbo
force-pushed
the
1.20-pollidisiac-suspicious-flowers
branch
from
8112d39 to
b80a5b1
Compare
|
I didn't test this, but i assume you did, and the code looks fine now. Thanks! |
I did, only missing the multiple item entities case earlier. |
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes smaller optimizations to the finding and feeding logic: