Improve Force Relay/Lens movement logic for block structures #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixes VazkiiMods#3917, VazkiiMods#4411, and VazkiiMods#4509) - fix pushing the wrong way if Force Relay is part of a retracting sticky piston's block structure - don't assume that the location where the force push seemingly originates from contains an unmovable block - updated/expanded tests to cover movement behavior in (potentially nested) block structures or with sticky pistons
|
tbh this logic is too complicated for me to understand anymore, so just gonna trust you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #3917, #4411, and #4509)