Optimized mana enchanter multiblock checking #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,6 +137,8 @@ public class ManaEnchanterBlockEntity extends BotaniaBlockEntity implements Mana | |||
|
|
|||
| public int stage3EndTicks = 0; | |||
|
|
|||
| private transient int idleTicks = 0; | |||
| return switch (axis) { | ||
| case X -> Rotation.NONE; | ||
| case Z -> Rotation.CLOCKWISE_90; | ||
| default -> null; |
There was a problem hiding this comment.
you could just throw here and elide the null check on the caller side, this is never going to be Y
TheRealWormbo
force-pushed
the
1.20-mana-enchanter-optimization
branch
from
cad1cd1 to
279ad82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #4388, the enchanter no longer assumes its rotation could change from one tick to another and performs its structure validation at a much reduced rate while it is idle.