Reminder for stack size limit with Ring of Loki #4396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some map colors for things that didn't have them or that previously depended on materials
ItemStack.matches() will return false if the two item stacks don't have the same number of items, which breaks corporea blocks. ItemStack.isSameItemSameTags() will check the tags only.
There's a choice between buffering up Item objects so that Creative tab filling event can read it, or registering a new event handler for every single item. I opted for the latter as it more clearly attributes that memory usage to Botania. Note that Forge floating flower rendering still crashes the creative tab so I can't actually test it quite yet.
Both loaders can now load from non-minecraft namespaces
Not worth the complexity
1.19.4 DFU optimizations in vanilla have made this unnecessary
Spawners no longer come with an entity configured by default so we have to give it one
Who knows how long it's been broken but it works again
Doesnt make sense to be up there
Untested, let's see if this works
Also to test previous commit
…ermission errors also dummy bump the site again
A finished pie is now a full circle, instead of a circle with a missing line of pixels. An unstarted pie is still invisible.
Suggested by lolkazu
Suggested by Wormbo
TheRealWormbo
force-pushed
the
1.19-loki-ring-stack-size
branch
from
fe5aae8 to
9eb217d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3668 by mentioning the potential limitations of placing blocks directly from a stack of block items held in hand.