Unable to be used in Division without subidivions

[hatoriganzo]

I'm looking into implementing ControlCenter for Mexico. But so far I've been unable to make it work since it requires me to set subvisions allowed for training (cannot be null) and in Mexico we don't have subdivisions.

So users come up as
AMAS/MCO/

So, even trying No Subdivisions on that field shows

Is there anyway to allow for empty subdivisions in settings?

[hatoriganzo]

I managed to bruteforce it by setting the DB value to null. But now It will allow memebers from other divisions in as long as they don't have subdivisions either. For example it will allow APAC/PAC/ members.

[blt950]

Hi @hatoriganzo ,

Glad to hear you're considering Control Center. Honestly, we never implemented proper division-only support as it was never needed - until now.

May I suggest you to change these two lines below to oauth.mapping_division instead as a workaround? That way it'll put the division into subdivision so you are able to test the system. (For dev/test only ofc). You'll need to oauth login with the users you want to test again to refresh the data, or manually just set MCO into the subdivision field in db, and allowing MCO to apply in settings.

https://github.com/Vatsim-Scandinavia/controlcenter/blob/main/app/Console/Commands/UpdateMemberData.php#L96
https://github.com/Vatsim-Scandinavia/controlcenter/blob/main/app/Http/Controllers/OAuthController.php#L63

When you've decided that CC is the right tool, I can put some effort into adding proper division-only support. Just tag me again in here 😄 It shouldn't be hard to add the support, but my time is limited, so I'd like to know that you're going for it before I commit to this change.

[hatoriganzo]

Thanks, edited the lines and will report back!

[hatoriganzo]

Hey, after testing with students and seeing if Control Center adapts well to our workflow. We've decided to implemente it in VATMEX.

So we would formally like to ask support for Division Only.

Best regards!