VATSIM_CORE_API_TOKEN Env Variable not being properly read.

[hatoriganzo]

Environment
CC Version: ghcr.io/vatsim-scandinavia/control-center:v4
Host type: Docker Compose running on Portainer

Describe the bug
VATSIM API V2 token is not being read when configured per documentation as the VATSIM_CORE_API_TOKEN environment variable in the dockercompose.yml.

How to reproduce
Steps to reproduce the behavior:

1. Set VATSIM_CORE_API_TOKEN to a valid (Tested via Postman) API Core V2 Token.
2. Navigate to /users
3. Get Error fetching users from VATSIM API. Check if your token is correct error message.

Expected behavior
Working user page

Screenshots

Additional context
After some tracking, I noted the config variable is being assigned in config/vatsim.php line 15.

'core_api_token' => env('VATSIM_CORE_API_TOKEN', null),

Running php artisan tinker in the container I noticed the ENV variable is properly set but the config property stays null. Works with other variables assigned the same way tho.

[blt950]

Sorry, but I can't give you support on almost year old version (v4) when v6 is now the current one. Please update to v6 and let me know if the issue still persists.

[hatoriganzo]

Oh! (Might want to update the docs :P) Updating.

And yeah, the variable name changed that's why.

[blt950]

Can you link me to the docs where it told you to download to v4? I'll correct it

[hatoriganzo]

Sure! It's on the following pages:

https://docs.vatsca.org/controlcenter/latest/getting-started/
In the example docker-compose.yml

https://docs.vatsca.org/controlcenter/latest/installation/
Open up a terminal and pull the latest image with:
docker pull ghcr.io/vatsim-scandinavia/control-center:v4

[hatoriganzo]

Unfortunately, I'm still having issues with my API Key (Updated to V6.06). Although now the config is getting set correctly.

[bedrich-schindler]

If VATSIM_CORE_API_TOKEN is correctly set in .env file, try to call php artisan key:generate. This helps me when changing something in the config ...

Also try to call php artisan optimize:clear just to be sure that cache is cleared.

Call all the commands inside the container.

[hatoriganzo]

Ran both commands inside the container but the issue remains.

[blt950]

I don't understand why this wouldn't work for you unless the key is actually invalid or maybe an v1 key. Everything works on my end here.

Confirm this key of yours can be called in the https://api.vatsim.net/v2/ API successfully?

[bedrich-schindler]

I personally do not use Docker on production, but what about this? https://docs.vatsca.org/controlcenter/latest/getting-started/#add-the-docker-compose-file. Environment is specified in docker-compose file in this example. I do not know how @hatoriganzo configured CC, but can't be this problem? You can also specify .env file using https://docs.docker.com/compose/how-tos/environment-variables/set-environment-variables/#use-the-env_file-attribute

But I am just guessing and throwing some stuff that came up to my mind

[bedrich-schindler]

Also, @hatoriganzo, did you check that you have latest image? From my experience, sometimes I must explicitly rebuild the image otherwise old tag is installed (v4 instead v6). Something like docker compose --build --no-cache ...

[blt950]

Since @hatoriganzo already did tinker and vatsim.core_api_token and got back his key, I'd assume the key itself is available.
For checking the version, look at the bottom left in sidebar.

[hatoriganzo]

Yeah I'm starting to think the key is the issue. It was just given to me from the dev team but I'll inquiry with them. Do you know any endpoint in the API that REQUIRES the key so I can properly test?

[blt950]

https://vatsim.dev/api/core-api/orgs-api-subdivision-roster

[hatoriganzo]

Yeah, it's working :c

[hatoriganzo]

Since @hatoriganzo already did tinker and vatsim.core_api_token and got back his key, I'd assume the key itself is available. For checking the version, look at the bottom left in sidebar.

Confirmed 6.0.6

[blt950]

I found out why.. Because the API calls the subdivision call instead of division😅😅

controlcenter/app/Http/Controllers/UserController.php

Line 440 in 4c52b19

$url = sprintf('https://api.vatsim.net/v2/orgs/subdivision/%s', config('app.owner_code'));

If you change this to the division call instead?

[hatoriganzo]

Changed the code and. 🥁

It worked

[hatoriganzo]

Marking as closed as related to #1080.