fix: replace dates with Eloquent's casts

Replaces $dates, which have been deprecated for some time, with $casts. In Laravel 10, $dates are gone, making this a necessary fix.
Vatsim-Scandinavia · Sep 28, 2023 · 7229da7 · 7229da7
1 parent dc66461
commit 7229da7
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 29 deletions.
diff --git a/app/Models/ActivityLog.php b/app/Models/ActivityLog.php
@@ -8,8 +8,8 @@ class ActivityLog extends Model
 {
     public $timestamps = false;
 
-    protected $dates = [
-        'created_at',
+    protected $casts = [
+        'created_at' => 'datetime',
     ];
 
     public function user()

diff --git a/app/Models/AtcActivity.php b/app/Models/AtcActivity.php
@@ -10,10 +10,10 @@ class AtcActivity extends Model
 
     protected $fillable = ['user_id', 'hours', 'start_of_grace_period'];
 
-    protected $dates = [
-        'created_at',
-        'updated_at',
-        'start_of_grace_period',
+    protected $casts = [
+        'created_at' => 'datetime',
+        'updated_at' => 'datetime',
+        'start_of_grace_period' => 'datetime',
     ];
 
     public function user()

diff --git a/app/Models/Endorsement.php b/app/Models/Endorsement.php
@@ -9,11 +9,11 @@ class Endorsement extends Model
 {
     use HasFactory;
 
-    protected $dates = [
-        'valid_from',
-        'valid_to',
-        'created_at',
-        'updated_at',
+    protected $casts = [
+        'valid_from' => 'datetime',
+        'valid_to' => 'datetime',
+        'created_at' => 'datetime',
+        'updated_at' => 'datetime',
     ];
 
     public function ratings()

diff --git a/app/Models/OneTimeLink.php b/app/Models/OneTimeLink.php
@@ -14,8 +14,8 @@ class OneTimeLink extends Model
 
     public $timestamps = false;
 
-    protected $dates = [
-        'expires_at',
+    protected $casts = [
+        'expires_at' => 'datetime',
     ];
 
     /**
@@ -45,7 +45,7 @@ public function getLink()
      */
     public function reportType()
     {
-        return self::TRAINING_REPORT_TYPE == $this->training_object_type;
+        return $this->training_object_type == self::TRAINING_REPORT_TYPE;
     }
 
     /**
@@ -55,7 +55,7 @@ public function reportType()
      */
     public function examinationType()
     {
-        return self::TRAINING_EXAMINATION_TYPE == $this->training_object_type;
+        return $this->training_object_type == self::TRAINING_EXAMINATION_TYPE;
     }
 
     /**

diff --git a/app/Models/Training.php b/app/Models/Training.php
@@ -14,9 +14,9 @@ class Training extends Model
 
     protected $table = 'trainings';
 
-    protected $dates = [
-        'started_at',
-        'closed_at',
+    protected $casts = [
+        'started_at' => 'datetime',
+        'closed_at' => 'datetime',
     ];
 
     /**

diff --git a/app/Models/TrainingExamination.php b/app/Models/TrainingExamination.php
@@ -10,10 +10,9 @@ class TrainingExamination extends TrainingObject
 
     protected $guarded = [];
 
-    protected $dates = ['examination_date'];
-
     protected $casts = [
         'draft' => 'boolean',
+        'examination_date' => 'datetime',
     ];
 
     public function position()

diff --git a/app/Models/TrainingInterest.php b/app/Models/TrainingInterest.php
@@ -8,9 +8,9 @@ class TrainingInterest extends Model
 {
     protected $guarded = [];
 
-    protected $dates = [
-        'deadline',
-        'confirmed_at',
+    protected $casts = [
+        'deadline' => 'datetime',
+        'confirmed_at' => 'datetime',
     ];
 
     public function training()

diff --git a/app/Models/TrainingReport.php b/app/Models/TrainingReport.php
@@ -10,10 +10,9 @@ class TrainingReport extends TrainingObject
 
     protected $guarded = [];
 
-    protected $dates = ['report_date'];
-
     protected $casts = [
         'draft' => 'boolean',
+        'report_date' => 'datetime',
     ];
 
     public function path()

diff --git a/app/Models/User.php b/app/Models/User.php
@@ -19,10 +19,10 @@ class User extends Authenticatable
 
     public $timestamps = false;
 
-    protected $dates = [
-        'last_login',
-        'last_activity',
-        'last_inactivity_warning',
+    protected $casts = [
+        'last_login' => 'datetime',
+        'last_activity' => 'datetime',
+        'last_inactivity_warning' => 'datetime',
     ];
 
     /**